From: Alan Meyer [vrmeyer@comcast.net] Sent: Friday, April 29, 2011 2:40 PM To: Osei-Poku, William Cc: Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline Subject: Re: Glossary term audio review is ready for testing Thanks for the quick test turnaround William. Comments are interspersed. On 04/29/2011 12:49 PM, Osei-Poku, William wrote: > Hi Alan, > I have tested the review tool. It works great and the users are > excited about it. Here are my notes from the review: > > 1. The zip files were not presented in a table form as we saw > in the meeting yesterday and as the page instruction states. > But I was able to click on the links to review them without any > problems. I am using Explorer 8. I only tested with Firefox. I must have a bug in my HTML that Firefox doesn't notice but IE does. I'll fix it. > 2. I think you had a note in the instructions that indicates > the spreadsheet will be **emailed** to you after the review but > I don't think that is the case. For all the ones I did, the > spreadsheet popped up after I clicked on save - which is fine. > I think making changes to the instructions should be fine. Ah yes. I had discussed this with Bob and thought he had suggested emailing the spreadsheet but in fact he meant that it should be sent to the browser. I'll keep it in the browser but fix the instructions that say it will be emailed. I'm also saving it on disk so that if someone completes a zip file but forgets to save the spreadsheet, we can pick it up again. > 3. I was able to generate multiple spreadsheets after I > completed my reviews. It looks like once you complete the > review, and as long as you have the browser open, you can > generate as many spreadsheets as possible. I am not sure if > this is a good idea or not or whether it could pose a problem > later on. I don't think it hurts anything, but I'll think about the right thing to do. > 4. Would it be possible to allow the user to control when the > spreadsheet is generated? That is, the spreadsheet should not > automatically pop up on the first save after the review is > complete. When the user completes the review, saves the work, > then a button called "Spreadsheet" or "Generate Spreadsheet" > could be displayed. When the button is clicked, the user should > then see the spreadsheet; either that or any other approach > where the user tells the program to generate the spreadsheet > should be fine. We can do that. Do you think it's important? > 5. We can also go ahead with sorting the term names by > language. Ideally, users would prefer the ability to choose the > language they want to see but that is not a pressing issue at > this point. I'll implement the sort, English, then Spanish. It would probably be best to sort as follows: Language, then review status, then CDR ID So all the English unreviewed would appear, then all the English rejects, then all the English approves, then all the Spanish in the same order. > I think none of these should prevent us from promoting it to > Bach. The IE problem seems pressing. I'll fix that and the email message ASAP. I may hold off on the others until Monday. I'll see what I can do. Alan > > Thanks, William > > -----Original Message----- > From: Alan Meyer [mailto:vrmeyer@comcast.net] > Sent: Friday, April 29, 2011 12:12 AM > To: Osei-Poku, William; Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline > Subject: Glossary term audio review is ready for testing > > Since Bugzilla is offline, I'm distributing this by email. We > can add it to Bugzilla later. > > Everything I've tested seems to be working. I can think of > useful changes to make, some of which we discussed at today's > meeting. You might think of some others too. However, following > the strategy we discussed at today's status meeting, I've tried > to make the basic functionality work first. We can then make > changes after that if we like. > > To test it, you must do the following: > > 1. Have an application configured in your browser to handle mp3 > files. > > Most users will already have one. Some will have one that > works but is not as fast or easy to use as a different one, so > you might want to experiment a bit or get help if needed. > > 2. Be a member of the "Glossary Maintainers" group on Mahler. > > I've limited access to this function to members of that group. > If we need a different or separate group, that's easy to setup. > > 3. Start the program as follows: > > On Mahler (and only on Mahler): > > Logon to the Administrative subsystem. > > Select Developers/System Administrators > > Select "Test Glossary Audio Review". > > > I have cleared out the database so that, currently all zip and > mp3 files are "Unreviewed". > > Testing doesn't require any knowledge of Spanish. The main tests > that I can think of, which anyone can do, are: > > 1. Can you call up a zip file for review? > > 2. Does it display all of the mp3 files with associated > information? > > 3. Can you modify the approval status? > > 4. Can you enter comments in the Reviewer Note field? > > 5. Can you save your changes? > > 6. When you look at the zipfile again, do the saved changes > appear? > > Remember that the rows that have been approved or rejected > are now at the bottom of the spreadsheet so you won't see > them where they were the last time you looked. > > 7. When all mp3 files in one zip file is the file properly > completed? > > a. If there were rejects, a correct spreadsheet was > produced and sent to your workstation. > > b. If there were no rejects, no spreadsheet was produced. > > c. The zip file now appears in the list of zip files as > "Completed" and is no longer available for reviewing. > > Because completing a file removes it from reviewing, each > file can only be completed once. However if anyone wants > to retest, let me know and I'll clear out the completion > flags, or all of the data, whichever is desired. > -- Alan Meyer AM Systems, Inc. Randallstown, MD USA vrmeyer@comcast.net From: Alan Meyer [vrmeyer@comcast.net] Sent: Friday, April 29, 2011 3:33 PM To: Osei-Poku, William Cc: Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline Subject: Re: Glossary term audio review is ready for testing On 04/29/2011 12:49 PM, Osei-Poku, William wrote: > 1. The zip files were not presented in a table form... Fixed. I had a ')' where I should have had a '>'. I stared at the whole thing for 10 minutes before I saw it. I see that the empty table cells in IE are not displayed as nicely as in Firefox. I tried the simple 30 second fix but it didn't work in this context. I may fix that if it doesn't take me too long to figure out. Otherwise I'll work on more important things. > 2. I think you had a note in the instructions that indicates > the spreadsheet will be **emailed** ... Fixed the instructions. I've reset the approvals on everything to "Unreviewed" so that more testing is possible if desired. -- Alan Meyer AM Systems, Inc. Randallstown, MD USA vrmeyer@comcast.net From: Alan Meyer [vrmeyer@comcast.net] Sent: Friday, April 29, 2011 3:52 PM To: Bob Kline Cc: Osei-Poku, William; Robin Harrison; Margaret Beckwith; Volker Englisch Subject: Re: Glossary term audio review is ready for testing On 04/29/2011 03:39 PM, Bob Kline wrote: > On Fri, Apr 29, 2011 at 3:32 PM, Alan Meyer > wrote: > > I see that the empty table cells in IE are not displayed as nicely > as in Firefox. I tried the simple 30 second fix > >
> > but it didn't work in this context. I may fix that if it doesn't > take me too long to figure out. Otherwise I'll work on more > important things. > > > Does something along these lines help? > > I'll check it out. "empty-cells: show" actually works by itself, but in the context of the existing CSS it doesn't - which is surprising. As I understand it, border-collapse shouldn't be needed but often is in some IE situations. In theory, you don't want it though in this application there aren't any empty rows where it would matter. It may be that the "border: black solid ..." will do the trick. But I've got other stuff to do at the moment. I'll get back to it later. -- Alan Meyer AM Systems, Inc. Randallstown, MD USA vrmeyer@comcast.net From: Alan Meyer [vrmeyer@comcast.net] Sent: Friday, April 29, 2011 3:55 PM To: Englisch, Volker (NIH/NCI) [C] Cc: Osei-Poku, William; Harrison, Robin (NIH/NCI) [E]; Beckwith, Margaret (NIH/NCI) [E]; Kline, Robert (NCI) Subject: Re: Glossary term audio review is ready for testing On 04/29/2011 03:39 PM, Englisch, Volker (NIH/NCI) [C] wrote: >> I see that the empty table cells in IE are not displayed as nicely as >> in Firefox. I tried the simple 30 second fix > > I believe this is only true for IE6 and IE7. IE8 actually does > display empty cells as empty cells. (Margaret and I had many discussions about this. :-) ) You may need to enter a space ( ) for IE to display the cell nicely. I thought about the   solution. I'm sure it will work in my situation, though it's a kludge. I may do it. I'll show it to you if you're interested on Monday. -- Alan Meyer AM Systems, Inc. Randallstown, MD USA vrmeyer@comcast.net From: Alan Meyer [vrmeyer@comcast.net] Sent: Monday, May 02, 2011 7:56 PM To: Osei-Poku, William Cc: Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline Subject: Re: Glossary term audio review is ready for testing I'll check it out right away. Alan On 5/2/2011 7:52 PM, Osei-Poku, William wrote: > I have verified this on Bach. There are 3 zip files listed in the table. The "Week_015.zip" file appears to be corrupted. When I click on the link, I get a python script error. "Week_012.zip" and "Week_012_Rev1.zip" files are Okay. > I will let you know any additional files that show up for review after we run the download tool. > > > William > > -----Original Message----- > From: Alan Meyer [mailto:vrmeyer@comcast.net] > Sent: Sunday, May 01, 2011 5:20 PM > To: Osei-Poku, William > Cc: Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline > Subject: Re: Glossary term audio review is ready for testing > > I installed the menu entry just below the Audio download tool, as requested. > > I tested using both Firefox and IE 8. Both looked okay to me. So I > reset the database to wipe out my test results and leave all of the > files unreviewed. > > Because we've had some confusion in the past about names, I put some > checking in my program for audio file names that are similar to what > we finally specified, but not exactly right. The check indeed found > one named "Week_12 Revision1" that does not conform and a later one > named "Week_012_Rev1.zip" that does conform to our latest spec. They > were not identical. > > I created a subdirectory called "QuestionableNames" and moved the > "...Revision1" file to there. I assume that file is indeed out of > date and not to be used. If that's wrong, we'll have to rename and reinstate it. > > Otherwise, as far as I know, we're good to go. > > Alan > > On 04/30/2011 12:11 PM, Osei-Poku, William wrote: >> Let it go on the main/first list under the CIAT/OCCM Staff menu, where the Audio download tool is currently located. >> >> Thanks, >> William >> >> >> -----Original Message----- >> From: Alan Meyer [mailto:vrmeyer@comcast.net] >> Sent: Friday, April 29, 2011 6:21 PM >> To: Osei-Poku, William >> Cc: Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline >> Subject: Re: Glossary term audio review is ready for testing >> >> On 04/29/2011 03:55 PM, Osei-Poku, William wrote: >> >> > I can see the table now I was able to confirm the fix for the >> > instructions. I think we are ready for production. >> >> William, >> >> I'll promote the software to Bach before Monday. Let me know where >> you want it to appear in the menus and I'll put it there. >> >> If anyone needs to use it who is not now in the Glossary Maintainers >> group, you'll need to add them. >> > > -- Alan Meyer AM Systems, Inc. Randallstown, MD, USA vrmeyer@comcast.net From: Alan Meyer [vrmeyer@comcast.net] Sent: Monday, May 02, 2011 9:30 PM To: Osei-Poku, William Cc: Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline Subject: Re: Glossary term audio review is ready for testing The crash report you saw was due to a bug in my error reporting routine. Fixing that, I was able to see the underlying error, which was: --------------------------------------------------------------- ExcelReader.Workbook constructor error: Exception Type: Exception msg: 'utf16' codec can't decode byte 0x31 in position 4: truncated data --------------------------------------------------------------- My first thought was that there was a Microsoft specific Unicode character in the spreadsheet that is not in the Unicode converter that Python uses. But I don't think that was the case. To find out if that was it, I deleted half the rows in the spreadsheet and still got the error. Then I restored the original and deleted the other half. Still got the error. Then I deleted all the rows except one row in English. But that didn't fix it. I next suspected that the problem had to do with an Excel binary encoding error caused by an incompatible version of Excel, but saving with the Windows Office 2007 on my computer didn't help. So I tried using the latest Open Office, saving in Excel 97 format - which was substantially smaller than the one that MS Excel produced. That changed the specific content of the error, but not the nature of it. I now get: --------------------------------------------------------------- ExcelReader.Workbook constructor error: Exception Type: Exception msg: 'utf16' codec can't decode byte 0x4c in position 0: truncated data --------------------------------------------------------------- Making another attempt, I loaded the Open Office version into MS Excel and saved it again. File sizes changed once again, but now it's back to the original error: --------------------------------------------------------------- ExcelReader.Workbook constructor error: Exception Type: Exception msg: 'utf16' codec can't decode byte 0x31 in position 4: truncated data --------------------------------------------------------------- My last attempt was to use MS Excel to convert the spreadsheet to a comma separated value MS-DOS text file, then read back into Excel and convert it again to Excel 97 .xls format. That actually worked! But it lost the Spanish accent characters, converting them to question marks. The audio review program can now read and display the contents of the file, but it contains terms like: arteriograf?a linfoma cut?neo de c?lulas T en estadio II We're clearly dealing with an Excel peculiarity that ExcelReader isn't equipped to handle, but I don't know exactly what it is. I'll have to look at this tomorrow with Bob, who wrote the ExcelReader module and understands the software and .xls format better than I do. If worst comes to worst and we can't find the format problem, I may be able to rescue this with a little more sophisticated conversion. Alan On 5/2/2011 7:56 PM, Alan Meyer wrote: > I'll check it out right away. > > Alan > > On 5/2/2011 7:52 PM, Osei-Poku, William wrote: >> I have verified this on Bach. There are 3 zip files listed in the >> table. The "Week_015.zip" file appears to be corrupted. When I click >> on the link, I get a python script error. "Week_012.zip" and >> "Week_012_Rev1.zip" files are Okay. >> I will let you know any additional files that show up for review >> after we run the download tool. >> >> >> William >> >> -----Original Message----- >> From: Alan Meyer [mailto:vrmeyer@comcast.net] >> Sent: Sunday, May 01, 2011 5:20 PM >> To: Osei-Poku, William >> Cc: Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline >> Subject: Re: Glossary term audio review is ready for testing >> >> I installed the menu entry just below the Audio download tool, as >> requested. >> >> I tested using both Firefox and IE 8. Both looked okay to me. So I >> reset the database to wipe out my test results and leave all of the >> files unreviewed. >> >> Because we've had some confusion in the past about names, I put some >> checking in my program for audio file names that are similar to what >> we finally specified, but not exactly right. The check indeed found >> one named "Week_12 Revision1" that does not conform and a later one >> named "Week_012_Rev1.zip" that does conform to our latest spec. They >> were not identical. >> >> I created a subdirectory called "QuestionableNames" and moved the >> "...Revision1" file to there. I assume that file is indeed out of >> date and not to be used. If that's wrong, we'll have to rename and >> reinstate it. >> >> Otherwise, as far as I know, we're good to go. >> >> Alan >> >> On 04/30/2011 12:11 PM, Osei-Poku, William wrote: >>> Let it go on the main/first list under the CIAT/OCCM Staff menu, >>> where the Audio download tool is currently located. >>> >>> Thanks, >>> William >>> >>> >>> -----Original Message----- >>> From: Alan Meyer [mailto:vrmeyer@comcast.net] >>> Sent: Friday, April 29, 2011 6:21 PM >>> To: Osei-Poku, William >>> Cc: Robin Harrison; Margaret Beckwith; Volker Englisch; Bob Kline >>> Subject: Re: Glossary term audio review is ready for testing >>> >>> On 04/29/2011 03:55 PM, Osei-Poku, William wrote: >>> >>> > I can see the table now I was able to confirm the fix for the >>> > instructions. I think we are ready for production. >>> >>> William, >>> >>> I'll promote the software to Bach before Monday. Let me know where >>> you want it to appear in the menus and I'll put it there. >>> >>> If anyone needs to use it who is not now in the Glossary Maintainers >>> group, you'll need to add them. >>> >> >> > > -- Alan Meyer AM Systems, Inc. Randallstown, MD, USA vrmeyer@comcast.net From: Englisch, Volker (NIH/NCI) [C] [volker@mail.nih.gov] Sent: Friday, April 29, 2011 3:40 PM To: Alan Meyer; Osei-Poku, William Cc: Harrison, Robin (NIH/NCI) [E]; Beckwith, Margaret (NIH/NCI) [E]; Kline, Robert (NCI) Subject: RE: Glossary term audio review is ready for testing > I see that the empty table cells in IE are not displayed as nicely as > in Firefox. I tried the simple 30 second fix I believe this is only true for IE6 and IE7. IE8 actually does display empty cells as empty cells. (Margaret and I had many discussions about this. :-) ) You may need to enter a space ( ) for IE to display the cell nicely. -- Volker Englisch Communications Technology Branch (CTB) Contractor: Sapient Government Services Email: volker@mail.nih.gov Phone: (301) 496-0102 (CTB)